[Ncep.list.nems.announce] NEMS update: nems ticket #43

Jun Wang - NOAA Affiliate jun.wang at noaa.gov
Tue Jul 23 15:26:26 UTC 2013


Thanks for all replies. I removed the line that was previously commented
out in gfs_qsub.IN.


Jun


On Tue, Jul 23, 2013 at 11:07 AM, Gerhard Theurich <
theurich at sourcespring.net> wrote:

> As Ratko and others point out, in the end it does boil down to the
> developer's own good judgment. It also seems that the NEMS coding policy
> is still developing. We also all seem to agree on favoring "removing"
> over "commenting out" in situations where it is pretty clear to the
> developer that the code should not be there. In less clear situations,
> the developer may decide to comment out the code instead, but in that
> case I propose that the commented out section should be accompanied by
> an explanation on why it is commented out, specifically expressing the
> fact that the code appears incorrect, unneeded, or outdated. Typically
> there should be a lot less of these "unclear" situations.
>
> Thank you for all the feedback!
>
> -Gerhard
>
> On 07/23/2013 07:48 AM, Jun Wang - NOAA Affiliate wrote:
> > Thanks, Gerhard. If the group are favor of removing questionable code
> > (In the case of gfs_qsub.IN, I guess someone was doing testing), I will
> > be certainly happy to do that.
> >
> >
> > Jun
> >
> >
> > On Tue, Jul 23, 2013 at 10:39 AM, weiyu yang <weiyu.yang at noaa.gov
> > <mailto:weiyu.yang at noaa.gov>> wrote:
> >
> >     I like this idea.
> >     Weiyu
> >
> >
> >     On 7/23/2013 10:13 AM, Gerhard Theurich wrote:
> >      > Hi, this is a general question for everybody about something I
> >     have been
> >      > trying to understand for a while now.
> >      >
> >      > It seems that the policy in NEMS is favoring "commenting out" over
> >      > "removing" questionable sections of code. It seems cleaner to me
> >     to just
> >      > remove sections of code that are not used any longer or appear to
> be
> >      > incorrect. And since everything is under revision control,
> nothing is
> >      > really ever lost anyway, and can be brought back easily. Just
> >     wondering
> >      > what the NEMS coding policy is with respect to removing sections
> of
> >      > code. Specifically with the change in gfs_qsub.IN under this
> >     ticket, I
> >      > had expected the questionable line to be deleted. I am just
> >     thinking of
> >      > the long term readability of the system, but may not be seeing
> >     the full
> >      > picture.
> >      >
> >      > Thanks,
> >      > -Gerhard
> >      >
> >      > On 07/23/2013 06:29 AM, Jun Wang - NOAA Affiliate wrote:
> >      >> Hi, all;
> >      >>
> >      >> I would like to commit a fix in gfs zeus job script. This fix is
> to
> >      >> avoid nems executable running twice in gfs regression tests on
> zeus.
> >      >>
> >      >> Above fix has no impact on regression test results, no impact on
> >      >> regression test on other machines.
> >      >>
> >      >> The code can be viewed on zeus at:
> >      >> /scratch1/portfolios/NCEPDEV/nems/noscrub/Jun.Wang/nems/trunk
> >      >>
> >      >> M       job/regression_tests/RegressionTests_zeus.log
> >      >> M       job/regression_tests/Compile_zeus.log
> >      >> M       job/regression_tests/gfs_qsub.IN
> >      >>
> >      >> NEMS ticket is:
> >      >>
> >      >> https://svnemc.ncep.noaa.gov/trac/nems/ticket/43
> >      >>
> >      >> I am planning to commit the code tomorrow morning. Thanks.
> >      >>
> >      >>
> >      >> Jun
> >      >>
> >      >>
> >      >>
> >      >> _______________________________________________
> >      >> Ncep.list.nems.announce mailing list
> >      >> Ncep.list.nems.announce at lstsrv.ncep.noaa.gov
> >     <mailto:Ncep.list.nems.announce at lstsrv.ncep.noaa.gov>
> >      >>
> >
> https://lstsrv.ncep.noaa.gov/mailman/listinfo/ncep.list.nems.announce
> >      >>
> >      > _______________________________________________
> >      > Ncep.list.nems.announce mailing list
> >      > Ncep.list.nems.announce at lstsrv.ncep.noaa.gov
> >     <mailto:Ncep.list.nems.announce at lstsrv.ncep.noaa.gov>
> >      >
> https://lstsrv.ncep.noaa.gov/mailman/listinfo/ncep.list.nems.announce
> >
> >     _______________________________________________
> >     Ncep.list.nems.announce mailing list
> >     Ncep.list.nems.announce at lstsrv.ncep.noaa.gov
> >     <mailto:Ncep.list.nems.announce at lstsrv.ncep.noaa.gov>
> >
> https://lstsrv.ncep.noaa.gov/mailman/listinfo/ncep.list.nems.announce
> >
> >
> >
> >
> > _______________________________________________
> > Ncep.list.nems.announce mailing list
> > Ncep.list.nems.announce at lstsrv.ncep.noaa.gov
> > https://lstsrv.ncep.noaa.gov/mailman/listinfo/ncep.list.nems.announce
> >
> _______________________________________________
> Ncep.list.nems.announce mailing list
> Ncep.list.nems.announce at lstsrv.ncep.noaa.gov
> https://lstsrv.ncep.noaa.gov/mailman/listinfo/ncep.list.nems.announce
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lstsrv.ncep.noaa.gov/pipermail/ncep.list.nems.announce/attachments/20130723/d1604fab/attachment-0001.html 


More information about the Ncep.list.nems.announce mailing list