[Ncep.hmon] hmon final script review

[Dan Iredell - NOAA Affiliate]

Hi Sam,
Thanks for your feedback. Lin and I have gone over them and addressed many
of these. Some of those files were not needed or moved to the rocoto
directory.
Dan

On Tue, Apr 25, 2017 at 10:32 AM, Samuel Trahan - NOAA Affiliate <
samuel.trahan at noaa.gov> wrote:

>
> GENERAL NOTES:
>
> Having a mix of three scripting languages may annoy NCO.  It is not
> realistic to change that now.  Just be aware they may be annoyed.
>
> J-JOB ISSUES:
>
> The dates and times should not be hard-coded.
> export PDY=20160928
> priorymdh=2016092812 <(201)%20609-2812>
> cyc=18
>
>
> NWROOT should not be hard-coded.
> NWROOT=/gpfs/hps/emc/hwrf/noscrub/Lin.L.Zhu/save
>
> EX-SCRIPT ISSUES:
>
> exhmon_cpl - make_symlinks does not pass a logger
>
> exhmon_hycominit*.py - these three are identical except for one string.
> You should have one script, and pass the string as an argument or
> environment variable.
>
> exhmon_post*.py - same thing: three nearly identical scripts
>
> exhmon_nps_bc.py - many calls lack a logger= argument
>
> exhmon_nps_ic.py - a few calls lack logger= arguments
>
> USH ISSUES:
>
> conf.py - isn't this just a rewrite of the python core ConfigParser module?
>
> hmon_generate_vitals.py - having dev paths in this script may annoy NCO
>
> Sincerely,
> Sam Trahan
>
> _______________________________________________
> Ncep.hmon mailing list
> Ncep.hmon at lstsrv.ncep.noaa.gov
> https://www.lstsrv.ncep.noaa.gov/mailman/listinfo/ncep.hmon
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://www.lstsrv.ncep.noaa.gov/pipermail/ncep.hmon/attachments/20170425/19e891f6/attachment.html