[Ncep.hmon] hmon final script review
Dan Iredell - NOAA Affiliate
dan.iredell at noaa.gov
Tue Apr 25 18:25:35 UTC 2017
Thanks for your feedback. Lin and I have gone over them and addressed many
of these. Some of those files were not needed or moved to the rocoto
On Tue, Apr 25, 2017 at 10:32 AM, Samuel Trahan - NOAA Affiliate <
samuel.trahan at noaa.gov> wrote:
> GENERAL NOTES:
> Having a mix of three scripting languages may annoy NCO. It is not
> realistic to change that now. Just be aware they may be annoyed.
> J-JOB ISSUES:
> The dates and times should not be hard-coded.
> export PDY=20160928
> priorymdh=2016092812 <(201)%20609-2812>
> NWROOT should not be hard-coded.
> EX-SCRIPT ISSUES:
> exhmon_cpl - make_symlinks does not pass a logger
> exhmon_hycominit*.py - these three are identical except for one string.
> You should have one script, and pass the string as an argument or
> environment variable.
> exhmon_post*.py - same thing: three nearly identical scripts
> exhmon_nps_bc.py - many calls lack a logger= argument
> exhmon_nps_ic.py - a few calls lack logger= arguments
> USH ISSUES:
> conf.py - isn't this just a rewrite of the python core ConfigParser module?
> hmon_generate_vitals.py - having dev paths in this script may annoy NCO
> Sam Trahan
> Ncep.hmon mailing list
> Ncep.hmon at lstsrv.ncep.noaa.gov
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Ncep.hmon