<div dir="ltr"><div><div>Hi Sam,<br></div>Thanks for your feedback. Lin and I have gone over them and addressed many of these. Some of those files were not needed or moved to the rocoto directory.<br></div>Dan<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 25, 2017 at 10:32 AM, Samuel Trahan - NOAA Affiliate <span dir="ltr"><<a href="mailto:samuel.trahan@noaa.gov" target="_blank">samuel.trahan@noaa.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><br></div><div>GENERAL NOTES:<br><br></div><div>Having a mix of three scripting languages may annoy NCO. It is not realistic to change that now. Just be aware they may be annoyed.<br></div><div><br>J-JOB ISSUES:<br><br></div>The dates and times should not be hard-coded. <br><div>export PDY=20160928<br>priorymdh=<a href="tel:(201)%20609-2812" value="+12016092812" target="_blank">2016092812</a><br>cyc=18 <wbr> <wbr> <br><br></div><div>NWROOT should not be hard-coded.<br>NWROOT=/gpfs/hps/emc/hwrf/<wbr>noscrub/Lin.L.Zhu/save<br><br></div><div>EX-SCRIPT ISSUES:<br><br></div><div>exhmon_cpl - make_symlinks does not pass a logger<br><br></div><div>exhmon_hycominit*.py - these three are identical except for one string. You should have one script, and pass the string as an argument or environment variable.<br><br></div><div>exhmon_post*.py - same thing: three nearly identical scripts<br></div><div><br>exhmon_nps_bc.py - many calls lack a logger= argument<br><br>exhmon_nps_ic.py - a few calls lack logger= arguments<br><br></div><div>USH ISSUES:<br><br></div><div>conf.py - isn't this just a rewrite of the python core ConfigParser module?<br><br></div><div>hmon_generate_vitals.py - having dev paths in this script may annoy NCO<br><br></div><div>Sincerely,<br></div><div>Sam Trahan<br></div></div>
<br>______________________________<wbr>_________________<br>
Ncep.hmon mailing list<br>
<a href="mailto:Ncep.hmon@lstsrv.ncep.noaa.gov">Ncep.hmon@lstsrv.ncep.noaa.gov</a><br>
<a href="https://www.lstsrv.ncep.noaa.gov/mailman/listinfo/ncep.hmon" rel="noreferrer" target="_blank">https://www.lstsrv.ncep.noaa.<wbr>gov/mailman/listinfo/ncep.hmon</a><br>
<br></blockquote></div><br></div>