[Ncep.hmon] hmon final script review
Samuel Trahan - NOAA Affiliate
samuel.trahan at noaa.gov
Tue Apr 25 14:32:45 UTC 2017
Having a mix of three scripting languages may annoy NCO. It is not
realistic to change that now. Just be aware they may be annoyed.
The dates and times should not be hard-coded.
NWROOT should not be hard-coded.
exhmon_cpl - make_symlinks does not pass a logger
exhmon_hycominit*.py - these three are identical except for one string.
You should have one script, and pass the string as an argument or
exhmon_post*.py - same thing: three nearly identical scripts
exhmon_nps_bc.py - many calls lack a logger= argument
exhmon_nps_ic.py - a few calls lack logger= arguments
conf.py - isn't this just a rewrite of the python core ConfigParser module?
hmon_generate_vitals.py - having dev paths in this script may annoy NCO
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Ncep.hmon