[Ncep.list.nems.announce] Intent to commit to NEMS trunk: NEMS Ticket #166: Removal of #ifdef WITH_NUOPC logic

gerhard.j.theurich gerhard.j.theurich at noaa.gov
Wed May 4 12:20:46 UTC 2016


    
Patrick, sounds good. Thank you,-Gerhard 

-------- Original message --------
From: Patrick Tripp <patrick.tripp at noaa.gov> 
Date: 5/4/2016  05:13  (GMT-08:00) 
To: Gerhard Theurich <theurich at sourcespring.net>, Mark Iredell <Mark.Iredell at noaa.gov>, NEMS developers <ncep.list.nems.announce at lstsrv.ncep.noaa.gov> 
Subject: Re: [Ncep.list.nems.announce] Intent to commit to NEMS trunk: NEMS
  Ticket #166: Removal of #ifdef WITH_NUOPC logic 

Gerhard,

I'm running a couple of tests this morning. I'll let you know when they 
are done so you can commit.

Thanks - Patrick

On 5/3/16 5:09 PM, Gerhard Theurich wrote:
> Patrick, I ran the "rt.sh -s" on Theia last night, and it had finished 
> this morning when I checked, before I sent out the "intent to commit 
> to trunk" email. I only ran the SLG/coldstart coupled compset on 
> Theia, and it came back clean.
>
> I am okay to wait until tomorrow. Do you want me to commit at the 24h 
> mark (7:45amET), or do you want some more time testing? Also I know 
> with Theia down, there was limited chance to look at my working copy 
> since that is on Theia. Do you think we need to give other developers 
> more time to review before committing the change?
>
> -Gerhard
>
> On 05/03/2016 02:02 PM, Patrick Tripp wrote:
>> Gerhard,
>>
>> Theia has been down most of the day. Were you able to run the compsets
>> before the outtage?
>> The previous commit to trunk compsets ran fine on wcoss. I haven't
>> looked at theia yet.
>> I have some things to do tonight until after 9:30PM EDT.
>>
>> I think you should hold off on the commit until tomorrow.
>>
>> Thanks - Patrick
>>
>> On 5/3/16 4:31 PM, Gerhard Theurich wrote:
>>> Hi Mark and Patrick,
>>>
>>> Same question as yesterday, may I commit the NEMS change as per ticket
>>> #166 to the trunk tonight? Jun already committed the associated GSM
>>> changes to the GSM trunk, so just the NEMS part is missing. Thanks,
>>>
>>> -Gerhard
>>>
>>> On 05/03/2016 04:47 AM, Gerhard Theurich wrote:
>>>> Hi team,
>>>>
>>>> The post-merge code cleanup of removing the "#ifdef WITH_NUOPC" 
>>>> logic in
>>>> NEMS is ready for commit (see ticket below for details). I ran the
>>>> "rt.sh -s" test on Theia, and it is available for review at
>>>> theia:/scratch4/NCEPDEV/nems/noscrub/Gerhard.Theurich/APPs/NEMSLegacy/NEMS/tests 
>>>>
>>>>
>>>>
>>>> There is an associated GSM trunk commit that is also in the queue.
>>>>
>>>> Thanks,
>>>> -Gerhard
>>>>
>>>> -------- Original Message --------
>>>> Subject: Re: NEMS Ticket #166: Removal of #ifdef WITH_NUOPC logic
>>>> Date: Tue, 03 May 2016 11:41:02 -0000
>>>> From: NEMS Trac Ticket <ncep.list.emc.nems.tickets at noaa.gov>
>>>> Reply-To: ncep.list.emc.nems.tickets at noaa.gov
>>>> CC: ncep.list.emc.nems.tickets at noaa.gov
>>>>
>>>> #166: Removal of #ifdef WITH_NUOPC logic
>>>> --------------------------+------------------------
>>>>     Reporter:  theurich@…   |      Owner:  theurich@…
>>>>         Type:  enhancement  |     Status:  accepted
>>>>     Priority:  major        |  Milestone:
>>>>    Component:  NEMS         |    Version:  3.1
>>>> Resolution:               |   Keywords:
>>>> --------------------------+------------------------
>>>> Changes (by theurich@…):
>>>>
>>>>    * status:  new => accepted
>>>>    * owner:   => theurich@…
>>>>
>>>>
>>>> Comment:
>>>>
>>>>    The NEMS code with #ifdef WITH_NUOPC logic removed is ready for
>>>> commit. It
>>>>    is available on a branch
>>>> https://svnemc.ncep.noaa.gov/projects/nems/branches/theurich/removeIfdef. 
>>>>
>>>>
>>>>
>>>>    Eight files needed to be touched:
>>>>
>>>>    M       src/ESMFVersionDefine_ESMF_NUOPC.h
>>>>    M       src/atmos/share/module_CPLFIELDS.F90
>>>>    M       src/atmos/module_ATM_GRID_COMP.F90
>>>>    M       src/module_EARTH_GRID_COMP.F90
>>>>    M       src/module_MEDIATOR_methods.F90
>>>>    M       src/module_MEDIATOR_SpaceWeather.F90
>>>>    M       src/module_EARTH_INTERNAL_STATE.F90
>>>>    M       src/module_MEDIATOR.F90
>>>>
>>>>    A working copy of the entire NEMS source with changes is available
>>>> for
>>>>    review at
>>>> Theia:/scratch4/NCEPDEV/nems/noscrub/Gerhard.Theurich/APPs/UGCS-
>>>>    Seasonal/NEMS.
>>>>
>>>>    *gjt*
>>>>
>>>> -- 
>>>> Ticket URL:
>>>> <https://svnemc.ncep.noaa.gov/trac/nems/ticket/166#comment:1>
>>>> NEMS <https://svnemc.ncep.noaa.gov/trac/nems>
>>>> My example project
>>>>
>>>>
>>>> _______________________________________________
>>>> Ncep.list.nems.announce mailing list
>>>> Ncep.list.nems.announce at lstsrv.ncep.noaa.gov
>>>> https://www.lstsrv.ncep.noaa.gov/mailman/listinfo/ncep.list.nems.announce 
>>>>
>>>>
>>>>
>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://www.lstsrv.ncep.noaa.gov/pipermail/ncep.list.nems.announce/attachments/20160504/1dbf1844/attachment.html 


More information about the Ncep.list.nems.announce mailing list