<html><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8"></head><body>
<div>Patrick, sounds good. Thank you,</div><div>-Gerhard </div><br><br>-------- Original message --------<br>From: Patrick Tripp <patrick.tripp@noaa.gov> <br>Date: 5/4/2016 05:13 (GMT-08:00) <br>To: Gerhard Theurich <theurich@sourcespring.net>, Mark Iredell <Mark.Iredell@noaa.gov>, NEMS developers <ncep.list.nems.announce@lstsrv.ncep.noaa.gov> <br>Subject: Re: [Ncep.list.nems.announce] Intent to commit to NEMS trunk: NEMS
Ticket #166: Removal of #ifdef WITH_NUOPC logic <br><br>Gerhard,<br><br>I'm running a couple of tests this morning. I'll let you know when they <br>are done so you can commit.<br><br>Thanks - Patrick<br><br>On 5/3/16 5:09 PM, Gerhard Theurich wrote:<br>> Patrick, I ran the "rt.sh -s" on Theia last night, and it had finished <br>> this morning when I checked, before I sent out the "intent to commit <br>> to trunk" email. I only ran the SLG/coldstart coupled compset on <br>> Theia, and it came back clean.<br>><br>> I am okay to wait until tomorrow. Do you want me to commit at the 24h <br>> mark (7:45amET), or do you want some more time testing? Also I know <br>> with Theia down, there was limited chance to look at my working copy <br>> since that is on Theia. Do you think we need to give other developers <br>> more time to review before committing the change?<br>><br>> -Gerhard<br>><br>> On 05/03/2016 02:02 PM, Patrick Tripp wrote:<br>>> Gerhard,<br>>><br>>> Theia has been down most of the day. Were you able to run the compsets<br>>> before the outtage?<br>>> The previous commit to trunk compsets ran fine on wcoss. I haven't<br>>> looked at theia yet.<br>>> I have some things to do tonight until after 9:30PM EDT.<br>>><br>>> I think you should hold off on the commit until tomorrow.<br>>><br>>> Thanks - Patrick<br>>><br>>> On 5/3/16 4:31 PM, Gerhard Theurich wrote:<br>>>> Hi Mark and Patrick,<br>>>><br>>>> Same question as yesterday, may I commit the NEMS change as per ticket<br>>>> #166 to the trunk tonight? Jun already committed the associated GSM<br>>>> changes to the GSM trunk, so just the NEMS part is missing. Thanks,<br>>>><br>>>> -Gerhard<br>>>><br>>>> On 05/03/2016 04:47 AM, Gerhard Theurich wrote:<br>>>>> Hi team,<br>>>>><br>>>>> The post-merge code cleanup of removing the "#ifdef WITH_NUOPC" <br>>>>> logic in<br>>>>> NEMS is ready for commit (see ticket below for details). I ran the<br>>>>> "rt.sh -s" test on Theia, and it is available for review at<br>>>>> theia:/scratch4/NCEPDEV/nems/noscrub/Gerhard.Theurich/APPs/NEMSLegacy/NEMS/tests <br>>>>><br>>>>><br>>>>><br>>>>> There is an associated GSM trunk commit that is also in the queue.<br>>>>><br>>>>> Thanks,<br>>>>> -Gerhard<br>>>>><br>>>>> -------- Original Message --------<br>>>>> Subject: Re: NEMS Ticket #166: Removal of #ifdef WITH_NUOPC logic<br>>>>> Date: Tue, 03 May 2016 11:41:02 -0000<br>>>>> From: NEMS Trac Ticket <ncep.list.emc.nems.tickets@noaa.gov><br>>>>> Reply-To: ncep.list.emc.nems.tickets@noaa.gov<br>>>>> CC: ncep.list.emc.nems.tickets@noaa.gov<br>>>>><br>>>>> #166: Removal of #ifdef WITH_NUOPC logic<br>>>>> --------------------------+------------------------<br>>>>> Reporter: theurich@… | Owner: theurich@…<br>>>>> Type: enhancement | Status: accepted<br>>>>> Priority: major | Milestone:<br>>>>> Component: NEMS | Version: 3.1<br>>>>> Resolution: | Keywords:<br>>>>> --------------------------+------------------------<br>>>>> Changes (by theurich@…):<br>>>>><br>>>>> * status: new => accepted<br>>>>> * owner: => theurich@…<br>>>>><br>>>>><br>>>>> Comment:<br>>>>><br>>>>> The NEMS code with #ifdef WITH_NUOPC logic removed is ready for<br>>>>> commit. It<br>>>>> is available on a branch<br>>>>> https://svnemc.ncep.noaa.gov/projects/nems/branches/theurich/removeIfdef. <br>>>>><br>>>>><br>>>>><br>>>>> Eight files needed to be touched:<br>>>>><br>>>>> M src/ESMFVersionDefine_ESMF_NUOPC.h<br>>>>> M src/atmos/share/module_CPLFIELDS.F90<br>>>>> M src/atmos/module_ATM_GRID_COMP.F90<br>>>>> M src/module_EARTH_GRID_COMP.F90<br>>>>> M src/module_MEDIATOR_methods.F90<br>>>>> M src/module_MEDIATOR_SpaceWeather.F90<br>>>>> M src/module_EARTH_INTERNAL_STATE.F90<br>>>>> M src/module_MEDIATOR.F90<br>>>>><br>>>>> A working copy of the entire NEMS source with changes is available<br>>>>> for<br>>>>> review at<br>>>>> Theia:/scratch4/NCEPDEV/nems/noscrub/Gerhard.Theurich/APPs/UGCS-<br>>>>> Seasonal/NEMS.<br>>>>><br>>>>> *gjt*<br>>>>><br>>>>> -- <br>>>>> Ticket URL:<br>>>>> <https://svnemc.ncep.noaa.gov/trac/nems/ticket/166#comment:1><br>>>>> NEMS <https://svnemc.ncep.noaa.gov/trac/nems><br>>>>> My example project<br>>>>><br>>>>><br>>>>> _______________________________________________<br>>>>> Ncep.list.nems.announce mailing list<br>>>>> Ncep.list.nems.announce@lstsrv.ncep.noaa.gov<br>>>>> https://www.lstsrv.ncep.noaa.gov/mailman/listinfo/ncep.list.nems.announce <br>>>>><br>>>>><br>>>>><br>>><br><br></body></html>