<div>Rahul,</div><div>You made a lot of unilateral changes without discussing with me.  I have to make some corrections to make it work on wcoss. You need to use the super package to understand what is really working.  KEEPDATA is used incurrent package, not my invention. Talk to me offline. Without vrfy fcst arch we cannot do anything at the moment.</div><div><br></div><div>Fanglin</div><div><br><div class="gmail_quote"><div>On Sat, Mar 11, 2017 at 12:07 PM FV3GFS Trac Ticket &lt;<a href="mailto:ncep.list.emc.fv3gfs_tickets@noaa.gov">ncep.list.emc.fv3gfs_tickets@noaa.gov</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">#11: Cycling workflow.<br class="gmail_msg"><br>-------------------------+-------------------------------------------------<br class="gmail_msg"><br>  Reporter:              |      Owner:  rahul.mahajan@…<br class="gmail_msg"><br>  rahul.mahajan@…        |     Status:  assigned<br class="gmail_msg"><br>      Type:              |  Milestone:<br class="gmail_msg"><br>  enhancement            |    Version:<br class="gmail_msg"><br>  Priority:  major       |   Keywords:<br class="gmail_msg"><br> Component:  component1  |  workflow,scripting,cycling,utilities<br class="gmail_msg"><br>Resolution:              |<br class="gmail_msg"><br>-------------------------+-------------------------------------------------<br class="gmail_msg"><br><br class="gmail_msg"><br>Comment (by rahul.mahajan@…):<br class="gmail_msg"><br><br class="gmail_msg"><br> Replying to [comment:23 fanglin.yang@…]:<br class="gmail_msg"><br> &gt; &#39;&#39;&#39;Merge Rahul Mahajan&#39;s branch to the trunk&#39;&#39;&#39;<br class="gmail_msg"><br> &gt;<br class="gmail_msg"><br> Fanglin,<br class="gmail_msg"><br><br class="gmail_msg"><br> Thank you for merging the branch into the [source:trunk].<br class="gmail_msg"><br><br class="gmail_msg"><br> I have some reservations on some of the changes that were made without<br class="gmail_msg"><br> giving me a chance to review and comment on them.<br class="gmail_msg"><br> Some are simply property changes, but some are script/source code changes<br class="gmail_msg"><br> and have not been reviewed or commented. Unilateral decisions are never a<br class="gmail_msg"><br> good idea.<br class="gmail_msg"><br><br class="gmail_msg"><br> I will highlight some of them here:<br class="gmail_msg"><br><br class="gmail_msg"><br> 1. We discussed extensively to make the {{{exglobal_fcst_fv3gfs.sh.ecf}}}<br class="gmail_msg"><br> machine independent. Anything machine related, such as loading modules, or<br class="gmail_msg"><br> setting {{{MPICH}}} related variables should be outside of this script.<br class="gmail_msg"><br> You agreed then, but now you seem to have rolled back on that.<br class="gmail_msg"><br><br class="gmail_msg"><br> 2. We agreed that the {{{exglobal_fcst_fv3gfs.sh.ecf}}} should be setup<br class="gmail_msg"><br> for cycling and can be modified for stand-alone or forecast-only runs.<br class="gmail_msg"><br> What you have added is logic for one or the other. I think we can do<br class="gmail_msg"><br> better than that.<br class="gmail_msg"><br><br class="gmail_msg"><br> 3. I have no objections to the FIX directory names, I used the name<br class="gmail_msg"><br> {{{FIX_DIR}}} because that was the standard in the {{{GFS}}}, if you want<br class="gmail_msg"><br> to call it {{{FIX_FV3}}}, I am Ok with that.<br class="gmail_msg"><br><br class="gmail_msg"><br> 4. You added a variable {{{$KEEPDATA}}}, which is in different than the<br class="gmail_msg"><br> logic followed in the existing GFS that if the {{{$DATA}}} directory<br class="gmail_msg"><br> exists, keep it, otherwise cleanup on exit. I am not opposed to this and<br class="gmail_msg"><br> if this is the standard you wish to follow, it should be communicated so<br class="gmail_msg"><br> that it is implemented elsewhere.<br class="gmail_msg"><br><br class="gmail_msg"><br> 5. There are several more changes that I did not make in my branch<br class="gmail_msg"><br> {{{source:branches/Rahul.Mahajan/EXP-cyc EXP-cyc}}} that are made as part<br class="gmail_msg"><br> of this {source:trunk} re-integration. They should be via their own<br class="gmail_msg"><br> branches, or atleast be documented in a ticket somewhere before re-<br class="gmail_msg"><br> integration to the [source:trunk], and reviewed. This should be a<br class="gmail_msg"><br> forbidden practice.<br class="gmail_msg"><br><br class="gmail_msg"><br> 6. As you know, the GSI repository holds a lot of the cycling scripts, and<br class="gmail_msg"><br> I have modified &#39;&#39;&#39;all&#39;&#39;&#39; of them with the standard that was in place<br class="gmail_msg"><br> before, with the new directory structure and file name conventions. As I<br class="gmail_msg"><br> have mentioned in the past, and re-iterate here, am more than willing to<br class="gmail_msg"><br> work with you to make the necessary changes that work towards unification<br class="gmail_msg"><br> of the EMC parallel workflow with the NCO workflow as the end goal. With<br class="gmail_msg"><br> the FV3 implementation, there should be no 2 ways (EMC or NCO) of doing<br class="gmail_msg"><br> things, that is my goal. Kindly guide me if I am misled to believe this is<br class="gmail_msg"><br> what I should be working towards.<br class="gmail_msg"><br><br class="gmail_msg"><br> 7. For now, I will update my branch [source:branches/Rahul.Mahajan/EXP-cyc<br class="gmail_msg"><br> EXP-cyc] currently at r89242 with the [source:trunk] at r89554, and<br class="gmail_msg"><br> discuss with you on how to address the issues outlined in this comment.<br class="gmail_msg"><br><br class="gmail_msg"><br> 8. I have deliberately not used {{{fcst.sh}}}, {{{post.sh}}}, and<br class="gmail_msg"><br> {{{vrfy.sh}}}, and to the extent none of the analysis or ensemble drivers<br class="gmail_msg"><br> either because there is no point in updating these scripts if we move<br class="gmail_msg"><br> towards the {{{JJOBS}}} way of doing our parallels. This should be handled<br class="gmail_msg"><br> by the workflow team anyways with input from you, ofcourse. As I mentioned<br class="gmail_msg"><br> earlier, I finished the last of the analysis related {{{exglobal}}}<br class="gmail_msg"><br> scripts and will now move towards a cycling capability with the<br class="gmail_msg"><br> {{{JJOBS}}} as the target.<br class="gmail_msg"><br><br class="gmail_msg"><br> Thanks,<br class="gmail_msg"><br> Rahul.<br class="gmail_msg"><br><br class="gmail_msg"><br><br class="gmail_msg"><br> &gt; Rahul&#39;s branch is<br class="gmail_msg"><br> <a href="https://svnemc.ncep.noaa.gov/projects/fv3gfs/branches/Rahul.Mahajan/EXP-" rel="noreferrer" class="gmail_msg" target="_blank">https://svnemc.ncep.noaa.gov/projects/fv3gfs/branches/Rahul.Mahajan/EXP-</a><br class="gmail_msg"><br> cyc/.  Please see <a href="https://svnemc.ncep.noaa.gov/trac/fv3gfs/ticket/11" rel="noreferrer" class="gmail_msg" target="_blank">https://svnemc.ncep.noaa.gov/trac/fv3gfs/ticket/11</a> for<br class="gmail_msg"><br> the details of his changes.<br class="gmail_msg"><br> &gt;<br class="gmail_msg"><br> &gt; 1.  Created a tag of the current trunk<br class="gmail_msg"><br> <a href="https://svnemc.ncep.noaa.gov/projects/fv3gfs/tags/fv3gfs_v3_20170307/" rel="noreferrer" class="gmail_msg" target="_blank">https://svnemc.ncep.noaa.gov/projects/fv3gfs/tags/fv3gfs_v3_20170307/</a><br class="gmail_msg"><br> &gt;<br class="gmail_msg"><br> &gt; 2.  Created a copy of Rahul&#39;s branch<br class="gmail_msg"><br> <a href="https://svnemc.ncep.noaa.gov/projects/fv3gfs/branches/fanglin.yang/EXP-" rel="noreferrer" class="gmail_msg" target="_blank">https://svnemc.ncep.noaa.gov/projects/fv3gfs/branches/fanglin.yang/EXP-</a><br class="gmail_msg"><br> cyc/, made further changes to a few scripts to ensure the package still<br class="gmail_msg"><br> works on CRAY.  fv3gfs_nc2nemsio.sh, fv3gfs_remap.sh, JGFS_POST.sh, pend,<br class="gmail_msg"><br> psub, fcst.sh, post.sh, vrfy.sh and arch.sh have also been updated to<br class="gmail_msg"><br> follow the new directory structure.<br class="gmail_msg"><br> &gt;<br class="gmail_msg"><br> &gt; 3. Reintegrate working branch back to the trunk<br class="gmail_msg"><br> &gt;<br class="gmail_msg"><br> &gt; SURGE-slogin1 &gt; svn -m &quot;reintegarte Rahul branch back to the trunk&quot;<br class="gmail_msg"><br> commit<br class="gmail_msg"><br> &gt; Sending        .<br class="gmail_msg"><br> &gt; Sending        gdas.v15.0.0<br class="gmail_msg"><br> &gt; Sending        gdas.v15.0.0/jobs<br class="gmail_msg"><br> &gt; Sending        gdas.v15.0.0/jobs/JGDAS_ANALYSIS_HIGH<br class="gmail_msg"><br> &gt; Sending        gdas.v15.0.0/jobs/JGDAS_ENKF_INFLATE_RECENTER<br class="gmail_msg"><br> &gt; Sending        gdas.v15.0.0/jobs/JGDAS_ENKF_INNOVATE_OBS<br class="gmail_msg"><br> &gt; Sending        gdas.v15.0.0/jobs/JGDAS_ENKF_SELECT_OBS<br class="gmail_msg"><br> &gt; Sending        gdas.v15.0.0/scripts<br class="gmail_msg"><br> &gt; Sending        gdas.v15.0.0/ush<br class="gmail_msg"><br> &gt; Sending        gfs.v15.0.0<br class="gmail_msg"><br> &gt; Sending        gfs.v15.0.0/jobs<br class="gmail_msg"><br> &gt; Sending        gfs.v15.0.0/scripts<br class="gmail_msg"><br> &gt; Sending        gfs.v15.0.0/ush<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/bin<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/bin/pend<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/bin/psub<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/exp_fv3gfs/para_config<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/exp_fv3gfs/submit_fv3gfs.sh<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/jobs<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/jobs/JGFS_POST.sh<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/jobs/arch.sh<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/jobs/fcst.sh<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/jobs/vrfy.sh<br class="gmail_msg"><br> &gt; Sending        gfs_workflow.v15.0.0/para/ush<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/docs/Release_Notes.global_shared_gsm.v14.1.0.txt<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/fix/fix_am<br class="gmail_msg"><br> &gt; Adding         global_shared.v15.0.0/parm/parm_fv3diag/diag_table_da<br class="gmail_msg"><br> &gt; Adding<br class="gmail_msg"><br> global_shared.v15.0.0/parm/parm_fv3diag/variable_table_da.txt<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/scripts<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/scripts/exglobal_analysis.sh.ecf<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/scripts/exglobal_fcst_fv3gfs.sh.ecf<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/scripts/exglobal_fcst_nems.sh.ecf<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/calc_increment.fd/Makefile<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/calc_increment.fd/Makefile.conf.cray<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/calc_increment.fd/Makefile.conf.theia<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/calc_increment.fd/constants.f90<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/calc_increment.fd/kinds.f90<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/calc_increment.fd/main.f90<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/calc_increment.fd/namelist_def.f90<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/global_chgres.fd<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/orog.fd/ml01rg2.x<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/regrid_nemsio.fd/Makefile<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/regrid_nemsio.fd/Makefile.conf.cray<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/regrid_nemsio.fd/Makefile.conf.jet<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/regrid_nemsio.fd/Makefile.conf.theia<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/regrid_nemsio.fd/Makefile_cray<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/regrid_nemsio.fd/constants.f90<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/regrid_nemsio.fd/fv3_interface.f90<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/regrid_nemsio.fd/gfs_nems_interface.f90<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/regrid_nemsio.fd/interpolation_interface.f90<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/regrid_nemsio.fd/kinds.f90<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/regrid_nemsio.fd/main.f90<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/regrid_nemsio.fd/mpi_interface.f90<br class="gmail_msg"><br> &gt; Sending<br class="gmail_msg"><br> global_shared.v15.0.0/sorc/regrid_nemsio.fd/namelist_def.f90<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/sorc/regrid_nemsio.fd/physcons.f90<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/ush<br class="gmail_msg"><br> &gt; Adding         global_shared.v15.0.0/ush/fv3gfs_calc_increment.sh<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/ush/fv3gfs_chgres.sh<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/ush/fv3gfs_driver_chgres.sh<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/ush/fv3gfs_nc2nemsio.sh<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/ush/fv3gfs_regrid_nemsio.sh<br class="gmail_msg"><br> &gt; Sending        global_shared.v15.0.0/ush/fv3gfs_remap.sh<br class="gmail_msg"><br> &gt; Transmitting file data ...................<br class="gmail_msg"><br> &gt; Committed revision 89554.<br class="gmail_msg"><br> &gt;<br class="gmail_msg"><br><br class="gmail_msg"><br>--<br class="gmail_msg"><br>Ticket URL: &lt;<a href="https://svnemc.ncep.noaa.gov/trac/fv3gfs/ticket/11#comment:24" rel="noreferrer" class="gmail_msg" target="_blank">https://svnemc.ncep.noaa.gov/trac/fv3gfs/ticket/11#comment:24</a>&gt;<br class="gmail_msg"><br>fv3gfs &lt;<a href="https://svnemc.ncep.noaa.gov/trac/fv3gfs" rel="noreferrer" class="gmail_msg" target="_blank">https://svnemc.ncep.noaa.gov/trac/fv3gfs</a>&gt;<br class="gmail_msg"><br>NGGPS FV3GFS Development<br class="gmail_msg"><br></blockquote></div></div>